Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docstring about QgsDateTimeEdit with NULL values #31855

Merged
merged 1 commit into from Sep 18, 2019

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Sep 17, 2019

Description

If you have a QgsDateTimeEdit, you mustn't call date() or time() on it as it can't handle NULL values. Only dateTime().

This PR needs to be backported for documentation in the API.

In a following PR, I can add date() and time() to return an empty QDateTime if needed. But I'm not sure if it can be backported.
If it is, then this PR can be updated.

It's not related to #31849

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@rldhont rldhont added API API improvement only, no visible user interface changes backport release-3_4 Documentation Changes to Documentation, README, INSTALL, etc labels Sep 17, 2019
@rldhont rldhont added this to the 3.10.0 milestone Sep 17, 2019
@rldhont rldhont merged commit 3ff8ca5 into qgis:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API improvement only, no visible user interface changes Documentation Changes to Documentation, README, INSTALL, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants