Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general.py #31899

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Update general.py #31899

merged 1 commit into from
Sep 20, 2019

Conversation

paulwittle
Copy link
Contributor

Description

Correction of error return type from bool to None (as per comments). This is to resolve unexpected exception message (AttributeError: 'bool' object has no attribute 'show') when algorithm is not found.

I'm not sure I've created this pull request correctly at all as I'm still new to open source development. Do I need to create a bug report and then rename this pull request?

I'm also pretty unsure regarding line endings etc as I'm using a Windows PC but I'm hoping it has not changed them as I've only changed one word and I edited the file directly in Visual Studio which should have recognised it as a python script.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

Correction of error return type from bool to None (as per comments). This is to resolve unexpected exception messages when algorithm is not found.
@m-kuhn
Copy link
Member

m-kuhn commented Sep 20, 2019

Hi @paulwittle

All good with this PR as is.

For future ones, if you change the commit message to be more verbose regarding what changed exactly that would be even better. Creating an issue report would be awesome but is not strictly required.

@m-kuhn m-kuhn merged commit 54dda46 into qgis:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants