Attribute table: please don't delete randomly! #32952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#32933 Pretty big fat bug isn't it ?
elpaso
added
backport release-3_4
Bug
@elpaso I'm sincerely thankful for all the effort, thanks.
yes, horrifying. |
nyalldawson
reviewed
Nov 20, 2019
instead of passing an index that could belong to one of the (three) models that live in the dual view. This hopefully makes the code a bit less error prone and readable. Fixes qgis#32952
nyalldawson
approved these changes
Nov 20, 2019
nyalldawson
pushed a commit
to nyalldawson/QGIS
that referenced
this pull request
Nov 21, 2019
instead of passing an index that could belong to one of the (three) models that live in the dual view. This hopefully makes the code a bit less error prone and readable. Fixes qgis#32952 (cherry picked from commit bcdbc3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32933
Pretty big fat bug isn't it ?
Funded by Spare Time (is) LTD