Revert 5c1cc4a40d84 in order to allow dashes in plugin directory names #32978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks ago I pushed the 5c1cc4a commit, so QGIS started interpreting dashes in zip file names as a version suffix delimiter (e.g. MyPlugin-0.0.1.zip should contain "MyPlugin" directory). The purpose was to end a frequent confusion: plugin authors was naming zip files like that and they were reporting those zips are not installable.
However, now it turned out (see #32968) that dashes are also used in the directory names for some time (40 plugins for QGIS 3.x vs zero for 2.x), they are even officially allowed: https://docs.qgis.org/3.4/en/docs/pyqgis_developer_cookbook/plugins/releasing.html#validation . And yes, QGIS is able to import packages with dashes in names.
In this situation I guess we have to revert that commit (although personally I'm obviously against playing with fire and allowing dashes in Python packages).
Checklist
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit