Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 5c1cc4a40d84 in order to allow dashes in plugin directory names #32978

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

borysiasty
Copy link
Member

@borysiasty borysiasty commented Nov 20, 2019

A few weeks ago I pushed the 5c1cc4a commit, so QGIS started interpreting dashes in zip file names as a version suffix delimiter (e.g. MyPlugin-0.0.1.zip should contain "MyPlugin" directory). The purpose was to end a frequent confusion: plugin authors was naming zip files like that and they were reporting those zips are not installable.

However, now it turned out (see #32968) that dashes are also used in the directory names for some time (40 plugins for QGIS 3.x vs zero for 2.x), they are even officially allowed: https://docs.qgis.org/3.4/en/docs/pyqgis_developer_cookbook/plugins/releasing.html#validation . And yes, QGIS is able to import packages with dashes in names.

In this situation I guess we have to revert that commit (although personally I'm obviously against playing with fire and allowing dashes in Python packages).

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

…been authorized at some point and we have a number of affected plugins now (please note personally I am opposed to putting dashes to Python package names). Fixes qgis#32968.
@borysiasty borysiasty added Plugins Regression Something which used to work, but doesn't anymore Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_10 labels Nov 20, 2019
@nyalldawson nyalldawson merged commit ffb38e8 into qgis:master Nov 20, 2019
@borysiasty borysiasty deleted the revert_5c1cc4a40d84 branch November 21, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Plugins Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants