Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask failing Windows tests #33263

Merged
merged 3 commits into from Dec 7, 2019
Merged

Mask failing Windows tests #33263

merged 3 commits into from Dec 7, 2019

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Dec 6, 2019

No description provided.

@roya0045
Copy link
Contributor

roya0045 commented Dec 6, 2019

I didn't follow this too closely but are the test failing only caused by the test environment itself or should we also aim to make them work in that platform eventually?

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 6, 2019

are the test failing only caused by the test environment itself

I don't know.

should we also aim to make them work in that platform eventually?

Yes, definitely

@jef-n
Copy link
Member

jef-n commented Dec 6, 2019

should we also aim to make them work in that platform eventually?

Yes, definitely

#33268 for the full picture (or any old nightly)

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 6, 2019

@jef-n feel free to close this one if it's superseded by something else.

@jef-n
Copy link
Member

jef-n commented Dec 6, 2019

@jef-n feel free to close this one if it's superseded by something else.

No, I just wanted to have the full picture in the other one (properly linked in github). I close it once it's done.

qgis_maptooladdfeatureline is apparently a flaky one on windows. There also have been successful runs.

@m-kuhn m-kuhn merged commit 2672c74 into qgis:master Dec 7, 2019
@m-kuhn m-kuhn deleted the azure_mark_failing branch December 7, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants