Being solid against field names variation in expressions on WFS #33266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the field name since then would be aliases and upper-/lower case written fieldnames be accepted in extensions and avoid a crash in getSpatialiteFieldNameFromUserVisibleName
signedav
changed the title
signedav
added
Bug
|
@rouault does this look good to you? |
|
@m-kuhn I think this has not been an issue on 3.10 since it used |
|
Oh right, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an expression had an alias or a field name written upper-/lowercase then it has not been able to map the cached spatialite field in
QgsBackgroundCachedFeatureIterator::buildRequestCache, what resulted in a crash.Since we get the field name used for the mapping of the cached field with
lookupField()it works with expressions containing aliases and case intensive written field names.