Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation on mac os due to missing GEOS headers #33334

Closed
wants to merge 1 commit into from

Conversation

PeterPetrik
Copy link
Contributor

this commit added qgsgeos.h to moc-ked files.

7c59700#diff-fd4c2ec27b0560e80d32a343a7a1de50R21

which causing build failure of mac-os nightlies with

CMakeFiles/qgis_gui.dir/qgis_gui_autogen/mocs_compilation.cpp.o -c /Users/admin/qgis/builds/nightly/build/src/gui/qgis_gui_autogen/mocs_compilation.cpp
In file included from /Users/admin/qgis/builds/nightly/build/src/gui/qgis_gui_autogen/mocs_compilation.cpp:7:
In file included from /Users/admin/qgis/builds/nightly/build/src/gui/qgis_gui_autogen/6SLW5EYZHQ/moc_qgspainteffectwidget.cpp:9:
In file included from /Users/admin/qgis/builds/nightly/build/src/gui/qgis_gui_autogen/6SLW5EYZHQ/../../../../../qgis/src/gui/effects/qgspainteffectwidget.h:170:
In file included from /Users/admin/qgis/builds/nightly/build/src/ui/ui_widget_glow.h:23:
In file included from /Users/admin/qgis/builds/nightly/qgis/src/gui/qgscolorrampbutton.h:21:
In file included from /Users/admin/qgis/builds/nightly/qgis/src/core/symbology/qgsstyle.h:30:
In file included from /Users/admin/qgis/builds/nightly/qgis/src/core/qgspallabeling.h:45:
In file included from /Users/admin/qgis/builds/nightly/qgis/src/core/qgslabelobstaclesettings.h:21:
/Users/admin/qgis/builds/nightly/qgis/src/core/geometry/qgsgeos.h:24:10: fatal error: 'geos_c.h' file not found
#include <geos_c.h>
         ^~~~~~~~~~
1 error generated.
make[2]: *** [src/gui/CMakeFiles/qgis_gui.dir/qgis_gui_autogen/mocs_compilation.cpp.o] Error 1

either geos should be added to gui cmakelist (patch) or qgsgeos.h should be moved to cpp file

@PeterPetrik PeterPetrik changed the title fix compilation on mac os due to missing GEOS library fix compilation on mac os due to missing GEOS headers Dec 11, 2019
@timlinux
Copy link
Member

Thanks for the fix!

@nyalldawson
Copy link
Collaborator

That include was an accident -- it can be removed now anyway!

@nyalldawson
Copy link
Collaborator

This was fixed in #33327

@PeterPetrik
Copy link
Contributor Author

PeterPetrik commented Dec 12, 2019

@nyalldawson I think there is different error with same origin

[ 67%] Building CXX object src/gui/CMakeFiles/qgis_gui.dir/qgis_gui_autogen/mocs_compilation.cpp.o
In file included from /Users/admin/qgis/builds/nightly/build/python/core/auto_generated/labeling/qgslabelsearchtree.sip:22:
In file included from /Users/admin/qgis/builds/nightly/qgis/src/core/labeling/qgslabelsearchtree.h:27:
/Users/admin/qgis/builds/nightly/qgis/src/core/qgsgenericspatialindex.h:30:10: fatal error: 'spatialindex/SpatialIndex.h' file not found
#include <spatialindex/SpatialIndex.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 67%] Generating analysis/sip_analysispart0.cpp, analysis/sip_analysispart1.cpp, analysis/sip_analysispart2.cpp, analysis/sip_analysispart3.cpp

1 error generated.

https://qgis.org/downloads/macos/qgis-macos-nightly.latest.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants