Spatial join c++ port (with follow ups) #33579
Conversation
…nd unjoinable features are not being collected
…n a separate unjoined feature output is set
…slower predicates Because we may be able to bypass the slower checks if the faster ones pass first
|
For reference: 2.5million point file, joined against 3500 polygon file, release build: Old python version: 208 seconds |
| qgsalgorithmjoinbylocation.cpp | ||
| --------------------- | ||
| begin : January 2020 | ||
| copyright : (C) 2020 by |
There was a problem hiding this comment.
Probably these should not be empty
| --------------------- | ||
| begin : January 2020 | ||
| copyright : (C) 2020 by | ||
| email : |
There was a problem hiding this comment.
Probably these lines should not be empty
| qgsalgorithmjoinbylocation.cpp | ||
| --------------------- | ||
| begin : January 2020 | ||
| copyright : (C) 2020 by Alexis Roy-Lizotte |
There was a problem hiding this comment.
I would like more something like Alex RL and alroyliz0 at gmail dot com.
|
Thanks for taking over, I knew that a more experienced programmer would implement this quicker but I wanted to help. Though I'm not sure if it helped or slowed things down. :/ Nice improvements also. |
|
@roya0045 , wanting to help is a fantastic state of mind, and the QGIS project has benefited from your contributions already. My main suggestion to you moving forward: as a 2020 new year resolution, force yourself to stop using QGIS' github repository as your test ground in favor of a proper development environment on your local machine. ATM, I have to mute most of your PRs to avoid having my inbox filling up with commits messages that would never reach the repository if you would compile locally. VM, dual boot, whatever. Make it your resolution :) Also, keep an open state of mind when senior developers are suggesting changes. We as a project are very, very lucky to have a couple of amazingly talented C++ / Qt gurus, and their knowledge is how we can all get better. Thanks for your contributions in 2019; I hope you can move beyond those obstacles so you can grow as a coder and contribute even more in 2020 😄 |
|
@nirvn Thanks for the feedback, as far as VM goes yes I now have one at work and this is how I have been able to improve my PR faster, but since its the holidays I am at home and didn't have access to my VM and with limited internet I only could do things on github directly. Though I agree that I should test things more and take more my time with things even when I think they are just a quick PR. And you are right that the core dev of Qgis are truly experts in their craft. Thanks for the support! |
Supersedes #33192, implementing the final cleanups and fixes required for merge