Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle field generated always as identity #33683

Merged
merged 4 commits into from
Jan 13, 2020
Merged

Oracle field generated always as identity #33683

merged 4 commits into from
Jan 13, 2020

Conversation

SebastienPeillet
Copy link
Contributor

Description

Fix #33681

It add functions (defaultValueClause and skipConstraintCheck) to evaluate default value for identity field (like "ISEQ$$_75967".nextval).

And in addFeatures function, always generated identity field are listed to be avoid in the insert request.

I add a test to check if the commit passes with an always generated identity field.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@SebastienPeillet
Copy link
Contributor Author

@troopa81 ping

@SebastienPeillet SebastienPeillet force-pushed the oracle_field_generated_always_as_identity branch from e188368 to 632cf7e Compare January 9, 2020 10:46
troopa81
troopa81 reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few comments to deal with

src/providers/oracle/qgsoracleprovider.cpp Show resolved Hide resolved
src/providers/oracle/qgsoracleprovider.cpp Outdated Show resolved Hide resolved
tests/testdata/provider/testdata_oracle.sql Outdated Show resolved Hide resolved
resolve review comments
71e7a87 
resolve review comments
@SebastienPeillet SebastienPeillet force-pushed the oracle_field_generated_always_as_identity branch from 92db947 to 71e7a87 Compare January 9, 2020 17:09
troopa81
troopa81 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

@github-actions github-actions bot added this to the 3.12.0 milestone Jan 10, 2020
@nyalldawson
Copy link
Collaborator

nyalldawson commented Jan 13, 2020 •
edited
Loading

@troopa81 are you happy with the revised version?

@nyalldawson nyalldawson added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers labels Jan 13, 2020
@troopa81
Copy link
Contributor

@nyalldawson yes I am, looks ok for me

@nyalldawson nyalldawson merged commit 34d3aaa into qgis:master Jan 13, 2020
@SebastienPeillet SebastienPeillet mentioned this pull request Feb 4, 2020
Closed
@SebastienPeillet SebastienPeillet mentioned this pull request Feb 19, 2020
Merged
This was referenced May 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson left review comments

@troopa81 troopa81 troopa81 approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Oracle, impossible to add feature with an identity field
3 participants
@SebastienPeillet @nyalldawson @troopa81