[BUGFIX] Read SLD TextSymbolizer: venderOptions to get advanced settings

[rldhont]

Description

VendorOptions element is used by QGIS is used to provide advanced settings.

Checklist

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include Fixes #11111 at the bottom of the commit message
• I have read the QGIS Coding Standards and this PR complies with them
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit
• I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

[rldhont]

@aaime and @luipir this PR completes #33725 can you review it

[luipir]

I could be boring, but lack of tests that this vendorOption font settings are propagated to font and settings.

other this this aspect, LGTM

Another question... this are QGIS or Geoserver vendor options? (I suppose qgis)

[rldhont]

These VendorOption are QGIS ones.

All the sld loader and reader tests have to be enhancent.

[aaime]

I cannot provide much of a review in terms of QGIS behavior, but the code looks legit, and I'm noticing that the vendor option names match the ones used in GeoServer.

[rldhont]

The vendor option names are the one used by QGIS in the save as SLD https://github.com/qgis/QGIS/blob/master/src/core/labeling/qgsvectorlayerlabeling.cpp#L457

[rldhont]

@luipir I test AroundPoint with maxDisplacement, can I merge ?

[luipir]

AroundPoint with maxDisplacement, can I merge ?

not clear to me how did you teste all settings set in the added code. IMHO could be interesting create a test SLD (or a set) as in

QGIS/tests/src/python/test_qgssymbollayer_readsld.py

Line 406 in c43e1d7

mFilePath = os.path.join(TEST_DATA_DIR, 'symbol_layer/external_sld/simple_line_with_text.sld')

where all parameters are tested.

Are there problems to create a test data set? If the problem is the feature freeze (tomorrow?), I agree to merge and then add new tests later. Is this the reason to merge without good test coverage?

[rldhont]

Thanks @luipir I will make tests next week.

[qgis-bot]

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-33813-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 0fa5a8f4d86978901678c277cfff55c730ec9837
# Push it to GitHub
git push --set-upstream origin backport-33813-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-33813-to-release-3_10.