Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read SLD TextSymbolizer set units to pixels #33852

Merged
merged 8 commits into from
Jan 16, 2020
Merged

Read SLD TextSymbolizer set units to pixels #33852

merged 8 commits into from
Jan 16, 2020

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Jan 16, 2020

Description

Backport #33725

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@rldhont rldhont added Backport Is a backport of another pull request Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling labels Jan 16, 2020
@rldhont rldhont added this to the 3.10.2 milestone Jan 16, 2020
luipir
luipir approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@luipir luipir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is backport bot disabled?

@rldhont
Copy link
Contributor

rldhont commented Jan 16, 2020

@luipir the backport-bot failed because my repository was Quantum-GIS and not QGIS.

@luipir
Copy link
Contributor

luipir commented Jan 16, 2020

Quantum-GIS

gosh it't time to clone it again!

@rldhont
Copy link
Contributor

rldhont commented Jan 16, 2020

I just renamed it

@rldhont rldhont merged commit a26ddd2 into qgis:release-3_10 Jan 16, 2020
@Gustry Gustry deleted the sld_pixels branch January 16, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luipir luipir luipir approved these changes

Assignees
No one assigned
Labels
Backport Is a backport of another pull request Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gustry @rldhont @luipir