Oracle provider: fix compiler warnings #33930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rouault
commented
Jan 20, 2020
rouault
commented
- Remove use of surfaceType variable that is never read
- Avoid self assignment of nRings variable
- Remove use of surfaceType variable that is never read - Avoid self assignment of nRings variable
rouault
force-pushed
the
oracle_fix_warnings
branch
from
2e48988
to
d6ed426
Compare
nyalldawson
approved these changes
Jan 20, 2020
|
Unrelated test failure (@manisandro you merged a PR which was reporting a build failure on the Windows azure builds -- fix inbound) |
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Jan 21, 2020
When fixing warnings of qgis#33930, I looked at the code that transforms a QGIS geometry of type MultiSurface to a Oracle geometry, and it appeared quite convoluted/risky (variables being reaffected with values of other variables), and not being able to deal with straight Polygon in MultiSurface. The reverse situation (Oracle MultiSurface to QGIS MultiSurface) had the same issue as well. The MultiCurve/CompoundCurve code has been modified similarly. There was no real bug. Just a sub-optimal behaviour on reading of MultiCurve from Oracle, where all parts where promoted to CompoundCurve, even when not strictly needed.
|
@nyalldawson Sorry about that and thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.