Modified layer prop. info text a bit smaller and first cell column a bit larger.

[Nikunjbansal99]

Modified layer prop. info text a bit smaller and first cell column a bit larger.

Description

I am new to this project even this is my first open source contribution but I know that whats the issue and how to fix it.
Issue #33955:
Makes layer prop. info text a bit smaller.
Issue #48996:
Makes layer prop. info text a bit smaller and first cell column a bit larger.

Checklist

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include Fixes #11111 at the bottom of the commit message
• I have read the QGIS Coding Standards and this PR complies with them
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit
• I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

[m-kuhn]

Hi, welcome!

Could you add a screenshot before / after?
It looks like there also is an issue with the issue numbers (48996 doesn't exist)

Just a minor thing for the future, make the first line of the commit message explicit (describe what has been done) and use Fix #xxxxx as the last line. This will make it easier to look through the commit history later on.

[m-kuhn]

It looks like #33955 was not an issue but a pull request already. @elpaso can you have a look, I think this specifies different values than your PR.

[Nikunjbansal99]

Hello Sir

issue numbers #48996 exist

[m-kuhn]

Hi @Nikunjbansal99

The number there is the id of the CI run on travis which is not valuable for the future or something that could be fixed or closed like an issue number. To check, click on the link in your last comment which results in a 404.

[Nikunjbansal99]

Okay Sir

[elpaso]

It looks like #33955 was not an issue but a pull request already. @elpaso can you have a look, I think this specifies different values than your PR.

Yes @Nikunjbansal99 can you give it a try to my PR #33955 ?

The values on the first col width are mostly the same, but I also made the text a bit smaller and I don't think there is a reason to reduce overall width.

[Nikunjbansal99]

@elpaso
Hello Sir,

YES, sure. The overall width is okay I guess. So Sir what is your suggestion should I create another pull Request?

[elpaso]

@elpaso
Hello Sir,

YES, sure. The overall width is okay I guess. So Sir what is your suggestion should I create another pull Request?

No need to, I've already done the fix, there is no need to make another one.

Just close this one.

[m-kuhn]

@Nikunjbansal99 sorry, there was a misunderstanding. To clarify: what you wanted to fix as an issue was actually a pull request already done by @elpaso (#33955). Feel free to open another pull request for an issue anytime!

[Nikunjbansal99]

@Nikunjbansal99 sorry, there was a misunderstanding. To clarify: what you wanted to fix as an issue was actually a pull request already done by @elpaso (#33955). Feel free to open another pull request for an issue anytime!

Okay Sir. This is my first try. I learned lot of things.

Thank You,
I like to contribute more and more.

[m-kuhn]

Great, looking forward!