Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.10] QgsExpression::referencedAttributeIndexes(): only report valid indices #33958

Merged
merged 3 commits into from Jan 21, 2020
Merged

[Backport 3.10] QgsExpression::referencedAttributeIndexes(): only report valid indices #33958

merged 3 commits into from Jan 21, 2020

Commits on Jan 21, 2020

  1. QgsExpression::referencedAttributeIndexes(): only report valid indices 

    If the expression was referencing a non-existing field, -1 was returned in the
result set, which caused later crashed in various providers, including the
Spatialite, Postgres, etc..., due to tried to dereference mFields.at(-1)

Discarding invalid indices is what is also done in
QgsFeatureRequest::OrderBy::usedAttributeIndices()

Fixes qgis#33878
    @rouault
    rouault committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    44c37be View commit details
    Browse the repository at this point in the history

  2. [BUGFIX] [Oracle] Make QgsOracleFeatureIterator() robust to reference… 

    …s to non existing fields in filter expression and order by
    @rouault
    rouault committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c586029 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX] [Virtual provider] Make QgsVirtualLayerFeatureIterator() reb… 

    …ust to references to non existing fields in filter expression
    @rouault
    rouault committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    992ad09 View commit details
    Browse the repository at this point in the history