Dataprovider ogr spatialite respect provider defaults #34012
Conversation
elpaso
added
Data Provider
Fixes qgis#33383 (for OGR, spatialite commit follows)
Fixes qgis#33383 Homogenization is not complete but at least there are test cases for the future.
elpaso
force-pushed
the
bugfix-gh33383-ogr-spatialite-respect-provider-defaults
branch
from
88f3b9b
to
f8e255e
Compare
| @@ -1380,7 +1385,7 @@ QVariant QgsOgrProvider::defaultValue( int fieldId ) const | |||
|
|
|||
| QString defaultVal = mDefaultValues.value( fieldId, QString() ); | |||
| if ( defaultVal.isEmpty() ) | |||
| return QVariant(); | |||
| return defaultVal; | |||
There was a problem hiding this comment.
I don't think this change is correct -- there's lots of existing code which checks if the returned value isValid(), and now that will return true instead of false (yet the default value doesn't exist)
There was a problem hiding this comment.
And wouldn't the check for mDefaultValues.hasKey be correct here?
Not that an empty string as default value is common, but it's at least in SQL terms it's valid.
There was a problem hiding this comment.
That was an attempt to homogenize the behavior, I will revert it and give up with the attempt.
But if you have a look to the tests, you'll see that the actual behavior of the two methods it is totally different between providers (I tested PG ogr and spatialite, but I expect that the others will not behave better).
What they return depends on a permutation of:
- the fact that it is a literal default or not
- the fact that it is a particular function/magic-value or not (CURRENT_TIMESTAMP for instance)
- which provider (and maybe which driver for OGR)
- if EvaluateDefaultValues is honored and its value
The least we can do is to document it in the API and possibly try to fix it for QGIS 4.
... also fixes "Autogenerate" for PKs Fixes qgis#34085
elpaso
deleted the
bugfix-gh33383-ogr-spatialite-respect-provider-defaults
branch
Fixes #33383
There is also an initial attempt to homogenize defaultValue and defaultValueClause between providers.
See also: https://lists.osgeo.org/pipermail/qgis-developer/2020-January/060007.html