Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG: fix default value for IDENTITY PKs #34017

Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 24, 2020

Fixes #29560 - PostgreSQL identity column not recognized properly

Fixes qgis#29560 - PostgreSQL identity column not recognized properly
@elpaso elpaso added Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_10 labels Jan 24, 2020
@elpaso elpaso merged commit ec4d9f6 into qgis:master Jan 27, 2020
@elpaso elpaso deleted the bugfix-gh29560-pg-identity-pk-default-values branch January 27, 2020 17:18
@qgis-bot
Copy link
Collaborator

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34017-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ec4d9f6871f52ffc2557866df71e5693b13ed047
# Push it to GitHub
git push --set-upstream origin backport-34017-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-34017-to-release-3_10.

@nyalldawson
Copy link
Collaborator

Looks like this change broke the Travis build -- can you investigate?

@elpaso
Copy link
Contributor Author

elpaso commented Jan 29, 2020

I see Travis green here, where should I look for the error?

@elpaso
Copy link
Contributor Author

elpaso commented Jan 30, 2020

@nyalldawson looking at it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL identity column not recognized properly
3 participants