Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow replacement of invalid variants in TextEditWrapper #34064

Closed
wants to merge 1 commit into from

Conversation

stev-0
Copy link
Contributor

@stev-0 stev-0 commented Jan 28, 2020

Description

Post merge of #30758 I noticed some odd behaviour with editing JSON fields - upon entering an invaliid JSON field, the invalid text persisted in the Text Edit when changing records. This was caused by #33660 which overlapped the original PR. This PR attempts to return to the old behaviour without affecting the fix in #33660

@troopa81 would be good to check this will not affect what you were doing

@stale
Copy link

stale bot commented Feb 13, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 13, 2020
@troopa81
Copy link
Contributor

@troopa81 would be good to check this will not affect what you were doing

Sorry to answer so lately. the idea of my fix IIRC was to prevent the modification of the line edit if the value hasn't change so I think your modification should be fine,

@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 13, 2020
@stev-0
Copy link
Contributor Author

stev-0 commented Feb 17, 2020

This already seems to be fixed in #34292

@stev-0 stev-0 closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants