Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget wrong values 0 doubles #34152

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 30, 2020

Fixes #34118

Because:

QVariant(0.0) == QVariant(QVariant.Double) -> True

but:

QVariant(0.0).isNull() == QVariant(QVariant.Double).isNull() -> False

Fixes qgis#34118

Because:

QVariant(0.0) == QVariant(QVariant.Double) -> True

but:

QVariant(0.0).isNull() == QVariant(QVariant.Double).isNull() -> False
@elpaso elpaso added Forms Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jan 30, 2020
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me, thanks @elpaso

@elpaso elpaso merged commit 4ca2bbb into qgis:master Jan 30, 2020
@elpaso
Copy link
Contributor Author

elpaso commented Jan 30, 2020

@troopa81 this needs backporting, correct?

@elpaso elpaso deleted the bugfix-gh34118-zero-double-widgets branch January 30, 2020 18:16
@qgis-bot
Copy link
Collaborator

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34152-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4ca2bbba94860b55a207446e0650cc4709708e8d
# Push it to GitHub
git push --set-upstream origin backport-34152-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-34152-to-release-3_10.

@troopa81
Copy link
Contributor

@troopa81 this needs backporting, correct?

Yes, I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QGIS 3.10.2 replace 0 to NULL
3 participants