Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFS case insensitive KVP URL query arguments check #34175

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 31, 2020

Fixes #34148

@elpaso elpaso added Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_10 labels Jan 31, 2020
@elpaso
Copy link
Contributor Author

elpaso commented Jan 31, 2020

@rouault mind having a look?

@rouault
Copy link
Contributor

rouault commented Jan 31, 2020

LGTM

@elpaso elpaso merged commit 0d55352 into qgis:master Jan 31, 2020
@elpaso elpaso deleted the bugfix-gh34148-wfs-case-sensitive-KVP branch January 31, 2020 15:00
@elpaso
Copy link
Contributor Author

elpaso commented Jan 31, 2020

@rouault thank you for stepping by 👍

@qgis-bot
Copy link
Collaborator

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34175-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 0d55352f9c8b2a48aab5ee3c9f201c40296eb2f0
# Push it to GitHub
git push --set-upstream origin backport-34175-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-34175-to-release-3_10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QGIS doesn't respect OGC guidelines for KVP parameters
3 participants