[WIP] BUG: postgres serial id conflict during an upsert join, fix #33148

[SebastienPeillet]

Description

fix #33148, @devfaz74 provides data test in it.

As explained in the issue, serial type column causes broken link between parent and child table using the upsert on edit feature.

The default values nextval('public.parent_id_seq'::regclass) is used to create the child entity but there is no update when parent entity is commited (and nextval('public.parent_id_seq'::regclass) is converted to int value during this step so the link is broken).

The (not obvious for users) solution is to activate the evaluateDefaultValues option in the project properties menu.

Maybe we should activate this option by default when a join is added with the upsertOnEdit flag. That what I propose in this PR, but I am not sure it's the best solution because :

• It doesn't keep information about previous state of evaluateDefaultValues, if the user remove the join in the future.
• I don't know if there is specific contraindications to the use of evaluateDefaultValues option...

I let the subject opened to other solution. If this one is accepted I will create the test in consequence.

Checklist :

• Commit messages are descriptive and explain the rationale for changes.

• Commits which fix bugs include Fixes #11111 at the bottom of the commit message. If this is your first pull request and you forgot to do this, write the same statement into this text field with the pull request description.

• New unit tests have been added for relevant changes

• You have run the scripts/prepare-commit.sh script (https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTING.md#contributing-to-qgis) before each commit.
  If you didn't do this, you can also run ./scripts/astyle-all.sh from your source folder.

• You have read the QGIS Coding Standards (https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them

[stale]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[SebastienPeillet]

Does someone has an opinion on this ?

[stale]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[stale]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.