Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map layer actions rendering in attribute table #34266

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

3nids
Copy link
Member

@3nids 3nids commented Feb 4, 2020

  • for a single feature, only Layer and SingleFeature actions are now listed, not MultipleFeatures anymore (showing Layer is debatable)
  • if a selection exists and the context menu is shown over a selected row, MultipleFeatures are listed in a new section (see screenshot)

image

@3nids 3nids requested a review from m-kuhn February 4, 2020 13:21
@3nids 3nids added backport release-3_10 Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Feb 4, 2020
src/gui/attributetable/qgsdualview.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Nyall Dawson <nyall.dawson@gmail.com>
@3nids 3nids merged commit 4fb42ae into qgis:master Feb 5, 2020
@3nids 3nids deleted the maplayeraction-multiple branch February 5, 2020 08:08
@qgis-bot
Copy link
Collaborator

qgis-bot commented Feb 5, 2020

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34266-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4fb42ae68dde644d450e8527110b7b50004195bc
# Push it to GitHub
git push --set-upstream origin backport-34266-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-34266-to-release-3_10.

3nids added a commit that referenced this pull request Feb 5, 2020
Backport Fix map layer actions rendering in attribute table (backport #34266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants