Fix crash when switching "apply default value on update" #34428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
the
Bug
|
@signedav this fixes the crash, but I'm not really sure it is the right approach, can you please have a look? The source of the issue is that the |
|
Sorry for no feedback. I'm abroad currently. Looks good so far but couldn't go deep into it... |
|
Take your time, I think you know better than me what's possibly going wrong in that code, but for now at least it won't crash. |
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Feb 17, 2020
…ly-default-value Fix crash when switching "apply default value on update"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34404