Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Read SLD TextSymbolizer PointPlacement for lines #34441

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Feb 12, 2020

Description

For lines, if labeling palcement is horizontal, the TextSymbolizer will contain PointPlacement instead of LinePlacement.

It completes #34223

For lines, if labeling palcement is horizontal, the TextSymbolizer will contain PointPlacement instead of LinePlacement.
@rldhont rldhont added Labeling Related to QGIS map labeling Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_10 labels Feb 12, 2020
@rldhont rldhont added this to the 3.12.0 milestone Feb 12, 2020
@rldhont rldhont merged commit 82324ec into qgis:master Feb 13, 2020
@qgis-bot
Copy link
Collaborator

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34441-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 82324ece0c9da91e1b3b2663cd70b0c3a8951965
# Push it to GitHub
git push --set-upstream origin backport-34441-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-34441-to-release-3_10.

@rldhont rldhont deleted the fix-read-sld-textsymbolizer-pointplacement-for-lines branch May 4, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants