WMS-T layers temporal constrains support #34497

Samweli · 2020-02-17T09:04:40Z

This PR adds the ability to constrain WMS temporal layers inside QGIS, that is, user will be able to constrain the datetime range for any temporal data source including from WMS-T providers.

This implementation lets user specify needed datetime range on the layer from the source tab on the layer properties dialog.

This PR include changes from the Temporal API here, the Temporal API is currently subject to changes.

Build up discussions about this can be found here and here .

Here below is an example of the workflow.

Screenshot of the consecutive results from the workflow.

Note: For instant based requests, specifying a range with equal begin and end datetime will result into using the specified datetime instant and not a range.

timlinux · 2020-02-17T15:22:24Z

CC @tomkralidis

roya0045 · 2020-02-17T22:05:34Z

@Samweli great PR!

nyalldawson

Great work @Samweli !

python/core/auto_generated/qgstemporalrangeobject.sip.in~HEAD

src/core/qgsmapsettings.cpp

src/core/qgsrendercontext.cpp

src/core/qgstemporalrangeobject.cpp~HEAD

src/core/qgstemporalrangeobject.cpp~HEAD~HEAD

src/gui/qgstemporallayerwidget.h

src/gui/qgstemporallayerwidget.cpp

src/core/raster/qgsrasterdataprovidertemporalproperties.h

src/core/qgsmaplayertemporalproperties.h

Samweli · 2020-02-18T07:33:31Z

@Samweli great PR!

Thanks @roya0045

Samweli · 2020-02-18T07:33:58Z

Great work @Samweli !

Thanks @nyalldawson !

nyalldawson · 2020-02-24T03:49:10Z

Can you please rebase (not merge) off the new master branch?

Samweli · 2020-02-24T05:35:48Z

Can you please rebase (not merge) off the new master branch?

Sure

m-kuhn · 2020-02-25T07:39:51Z

Awesome work !!

m-kuhn

I just did a basic code sanity check. @nyalldawson has a much better overview of the temporal api questions.
One thing that needs to be checked (I tagged some but didn't go through everywhere) is if dataProvider() or temporalCapabilities() could be nullptr.

src/providers/wms/qgswmsprovider.h

src/providers/wms/qgswmsdataitems.cpp

src/gui/raster/qgsrasterlayerproperties.cpp

src/gui/raster/qgsrasterlayertemporalpropertieswidget.cpp

Samweli · 2020-02-25T13:29:11Z

Awesome work !!

Thanks @m-kuhn

Samweli · 2020-02-25T13:29:58Z

I just did a basic code sanity check. @nyalldawson has a much better overview of the temporal api questions.
One thing that needs to be checked (I tagged some but didn't go through everywhere) is if dataProvider() or temporalCapabilities() could be nullptr.

Ok, will need to add checks for those.

timlinux · 2020-02-26T08:16:56Z

Thanks for the inputs @m-kuhn !

updates on tests and abstract temporal class updates on qgsabstracttemporal sip and tests update qgsabstracttemporal test updated docs moved qgsabstracttemporal class to qgstemporalrangeobject class as per review suggestions edits per review on qgs map canvas remove access of private members from qgstemporalrangeobject updated render context test and fix travis tests added new temporal property class added tests for temporal property added tests for temporal property added temporal widget ui temporal support in raster layers, from wms provider temporal properties in raster layer properties added abstract temporal class updates on tests and abstract temporal class updates on qgsabstracttemporal sip and tests update qgsabstracttemporal test updated docs temporal support in raster layers, from wms provider update qgsabstracttemporal test updated docs moved qgsabstracttemporal class to qgstemporalrangeobject class as per review suggestions edits per review on qgs map canvas updated render context test and fix travis tests added new temporal property class added new map layer temporal properties sub classes with tests updates on map layers temporal properties classes fix travis tests add read and write xml tests added abstract temporal class updates on tests and abstract temporal class updates on qgsabstracttemporal sip and tests update qgsabstracttemporal test updated docs edits per review on qgs map canvas temporal properties in raster layer properties temporal support in raster layers, from wms provider moved qgsabstracttemporal class to qgstemporalrangeobject class as per review suggestions edits per review on qgs map canvas remove access of private members from qgstemporalrangeobject updated render context test and fix travis tests added new temporal property class added new map layer temporal properties sub classes with tests updated layer times ui added advanced options in layer time constrains ui fix for refreshing wms layer after temporal properties update update on wms-t temporal properties added support for bi-temporal WMS-T

nyalldawson

Looks very close now, just a few minor things to tweak!

src/core/qgsdataprovider.h

src/core/raster/qgsrasterlayertemporalproperties.cpp

src/gui/raster/qgsrasterlayerproperties.cpp

src/gui/raster/qgsrasterlayertemporalpropertieswidget.h

src/providers/wms/qgswmsdataitems.cpp

src/core/raster/qgsrasterdataprovidertemporalcapabilities.h

nyalldawson · 2020-03-04T04:50:19Z

Looks good, just needs the build fixed now :)

src/core/raster/qgsrasterlayerrenderer.cpp

src/gui/raster/qgsrasterlayertemporalpropertieswidget.cpp

nyalldawson

GREAT! 🎉

Let's hope the CI is happy, and I'll merge...

DelazJ · 2020-03-05T06:01:46Z

Thanks @Samweli
I did not check the current code but from the gif, may I suggest to make the layer properties GUI more compact and look like other tabs: less spacing and margins, no group with single item? maybe are there alignment issues (gif was too fast to check)?

nyalldawson · 2020-03-05T06:07:51Z

@DelazJ I'll assist with that post-merge

DelazJ · 2020-03-05T06:09:36Z

Thanks @nyalldawson

nyalldawson · 2020-03-05T06:25:39Z

@elpaso seems the postgres raster tests are still being flaky -- see https://travis-ci.org/qgis/QGIS/jobs/658537736?utm_medium=notification&utm_source=github_status

DelazJ · 2020-03-05T09:52:13Z

@nyalldawson @3nids I'm a bit lost: Isn't "feature" label supposed to create issue report in docs repo? Or is "needs documentation" the single label trigger (though "changelog" seems to have triggered some - qgis/QGIS-Documentation#4953 qgis/QGIS-Documentation#4952 qgis/QGIS-Documentation#4951 - recently)?

pigreco · 2020-05-12T09:34:53Z

Please add Temporal label

Samweli force-pushed the wms-t_layer_time_constraints_v2 branch 3 times, most recently from e12f88a to 8c6d58b Compare February 17, 2020 20:36

nyalldawson reviewed Feb 18, 2020

View reviewed changes

Samweli force-pushed the wms-t_layer_time_constraints_v2 branch 4 times, most recently from 41ebd68 to 1b76e62 Compare February 19, 2020 15:58

Samweli mentioned this pull request Feb 20, 2020

QGIS Project temporal settings #34590

Merged

nyalldawson added the Feature label Feb 22, 2020

nyalldawson added this to the 3.14.0 milestone Feb 22, 2020

Samweli force-pushed the wms-t_layer_time_constraints_v2 branch 6 times, most recently from 840e347 to 675e90c Compare February 25, 2020 07:35

m-kuhn reviewed Feb 25, 2020

View reviewed changes

Samweli force-pushed the wms-t_layer_time_constraints_v2 branch from 675e90c to 2c04d22 Compare February 25, 2020 09:08

Samweli added 10 commits February 29, 2020 21:58

fixed conflicts

26137ba

removed status label in temporal properties

90a87da

fixed travis tests

a7bd1e2

suggested changes from the review

559a29e

added temporal capabilities tests

560ee19

ousing right wms reference request parameter

4f4ae3f

updated tests format

c03f891

added current layer range label

050a536

removed duplicate signal

8ecbef0

added checks for possible null temporal capabilities

c1275d0

Samweli force-pushed the wms-t_layer_time_constraints_v2 branch from e9d9f0f to c1275d0 Compare February 29, 2020 19:00

nyalldawson reviewed Mar 3, 2020

View reviewed changes

moved temporal range from provider to layer temporal properties

bdac804

Samweli added 3 commits March 4, 2020 17:28

saving and restoring temporal properties

0ab5af1

improved provider temporal capabilities tests

3b9f473

small tweaks,eg. remove of unwanted spaces

b385c8b

nyalldawson reviewed Mar 5, 2020

View reviewed changes

removed provider capabilities setting in temporal layer properties

498a05a

nyalldawson approved these changes Mar 5, 2020

View reviewed changes

nyalldawson merged commit c178276 into qgis:master Mar 5, 2020

Gustry added the Temporal Temporal filtering or animation label May 12, 2020

timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WMS-T layers temporal constrains support #34497

WMS-T layers temporal constrains support #34497

Samweli commented Feb 17, 2020 •

edited

Loading

timlinux commented Feb 17, 2020

roya0045 commented Feb 17, 2020

nyalldawson left a comment

Samweli commented Feb 18, 2020

Samweli commented Feb 18, 2020

nyalldawson commented Feb 24, 2020

Samweli commented Feb 24, 2020

m-kuhn commented Feb 25, 2020

m-kuhn left a comment

Samweli commented Feb 25, 2020

Samweli commented Feb 25, 2020

timlinux commented Feb 26, 2020

nyalldawson left a comment

nyalldawson commented Mar 4, 2020

nyalldawson left a comment

DelazJ commented Mar 5, 2020

nyalldawson commented Mar 5, 2020

DelazJ commented Mar 5, 2020

nyalldawson commented Mar 5, 2020

DelazJ commented Mar 5, 2020

pigreco commented May 12, 2020

WMS-T layers temporal constrains support #34497

WMS-T layers temporal constrains support #34497

Conversation

Samweli commented Feb 17, 2020 • edited Loading

timlinux commented Feb 17, 2020

roya0045 commented Feb 17, 2020

nyalldawson left a comment

Choose a reason for hiding this comment

Samweli commented Feb 18, 2020

Samweli commented Feb 18, 2020

nyalldawson commented Feb 24, 2020

Samweli commented Feb 24, 2020

m-kuhn commented Feb 25, 2020

m-kuhn left a comment

Choose a reason for hiding this comment

Samweli commented Feb 25, 2020

Samweli commented Feb 25, 2020

timlinux commented Feb 26, 2020

nyalldawson left a comment

Choose a reason for hiding this comment

nyalldawson commented Mar 4, 2020

nyalldawson left a comment

Choose a reason for hiding this comment

DelazJ commented Mar 5, 2020

nyalldawson commented Mar 5, 2020

DelazJ commented Mar 5, 2020

nyalldawson commented Mar 5, 2020

DelazJ commented Mar 5, 2020

pigreco commented May 12, 2020

Samweli commented Feb 17, 2020 •

edited

Loading