Fix some /Transfer/ annotations #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Looks good to merge |
| @@ -54,7 +54,7 @@ class QgsGeometryRubberBand: QgsMapCanvasItem | |||
| ~QgsGeometryRubberBand(); | |||
|
|
|||
| /** Sets geometry (takes ownership). Geometry is expected to be in map coordinates */ | |||
| void setGeometry( QgsAbstractGeometry* geom ); | |||
| void setGeometry( QgsAbstractGeometry* geom /Transfer/ ); | |||
There was a problem hiding this comment.
I think we should fix this and make it accept a QgsGeometry instead. That'll avoid any potential leaks/deleted pointer issues.
There was a problem hiding this comment.
Even better would be to merge QgsGeometryRubberBand with QgsRubberBand ;-)
There was a problem hiding this comment.
True. So what was the idea of QgsGeometryRubberBand ? @mhugent ?
|
Ready to ship? |
wonder-sk
added
the
Requires Changes!
|
@mhugo does it take a lot to fix this so we can remove it from the PR queue? |
|
@m-kuhn Sorry for the delay ! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally interested in fixing QgsGeometryRubberBand::setGeometry, but found some other candidates based on the surrounding comments ("takes ownership")