Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[delimitertext] fix watcher check ignored and harmful watcher created for iterator (fixes #15558) #3483

Merged
merged 1 commit into from
Sep 13, 2016
Merged

[delimitertext] fix watcher check ignored and harmful watcher created for iterator (fixes #15558) #3483

merged 1 commit into from
Sep 13, 2016

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Sep 13, 2016

This PR fixes two issues:

  • the [ x ] watch file setting was ignored (always on) as the code checked for the wrong query item
  • more importantly, a watcher was always created while creating the provider iterator, resulting in a QSocketNotice error on Qt5 (and possibly leading to a crasher, see PR Preview of tiled layers (WMTS) + support XYZ tile layers #3473)

@ccrook , I believe you are responsible for this provider. Does this look good to you? Thanks.

@nirvn nirvn mentioned this pull request Sep 13, 2016
Merged
@ccrook ccrook merged commit 92ed3be into qgis:master Sep 13, 2016
@m-kuhn
Copy link
Member

m-kuhn commented Sep 13, 2016

Should this also be backported?

@nirvn
Copy link
Contributor Author

nirvn commented Sep 13, 2016

@m-kuhn yes

@nyalldawson
Copy link
Collaborator

@nirvn working on it now

@qgib qgib mentioned this pull request May 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ccrook ccrook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nirvn @m-kuhn @nyalldawson @ccrook