-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][Symbology] Add percantage size unit for Raster Image Marker Layer symbology. #34869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature! Are you confident adding a unit test too?
@beketata , nice addition. If you want to go the extra mile -> it'd be nice to have the same feature applied to the raster fill symbol. |
Default value of Image width for Raster image fill is already Original. Or do you mean smth else? |
@beketata , right, but you could have it at say 50% (of original size) etc. |
According to tests details Test # 545: PyQgsPostgresRasterProvider is failed. |
I did the same patch adding new percentage size unit for Raster image fill layer. |
Unfortunately some checks were not successful. Could someone please advise me what to do next? |
Nothing, this test fail as there are some issue with our pipeline, just ignore it. |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
I received the stale[bot] notification that "this PR has not had any activity ... If there is no further activity ... it will be closed". |
The tests I would guess. |
Thank you all for the great support! |
@nyalldawson and @roya0045 were asking if you could add new tests? @roya0045 told you to not worry about the existing failing test if it's a false positive. (I didn't check) From the stale message above:
|
Description
According to Feature Request this patch adds new percentage (percents of original image size) size unit for Raster Image Marker Layer.