Make sure files are truncated before writing #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it is an issue only in Qt4. Looking at QIODevice::WriteOnly docs:
|
|
Maybe in 5.7. I was building with 5.5 when I experienced the issue... |
|
@wonder-sk so would you think this should be merged? |
|
Yeah I think so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be misinterpreting the Qt docs - but I believe there's a lot of cases in master where we should be opening files for writing with the QIODevice::Truncate flag.
I hit an issue today where a file exported from the color list (gpl file) was not being correctly truncated and tracked it down to a missing Truncate flag. But searching through the code I've found lots of other instances were the flag is missing, and am surprised that we haven't seen the consequences of this before...