Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal Navigation with VCR widget #34917

Closed
wants to merge 9 commits into from
Closed

Temporal Navigation with VCR widget #34917

wants to merge 9 commits into from

Conversation

Samweli
Copy link
Contributor

@Samweli Samweli commented Mar 6, 2020

Adds temporal navigation of QGIS temporal map layers using a new temporal dock widget.

Example
temporal_navigation_QGIS

Includes work from #34590

Note: This PR is part of the work from discussions found here and here .

@github-actions github-actions bot added this to the 3.14.0 milestone Mar 6, 2020
@jef-n jef-n added the Squash! Remember to squash this PR, instead of merging or rebasing label Mar 6, 2020
@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from ac8b130 to 96bf2f0 Compare March 6, 2020 23:55
@saberraz
Copy link
Contributor

saberraz commented Mar 7, 2020

Very nice!

@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from 2b3a82e to a00cdea Compare March 8, 2020 10:37
@Samweli Samweli removed the Squash! Remember to squash this PR, instead of merging or rebasing label Mar 8, 2020
@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from a00cdea to 4a25c6c Compare March 8, 2020 12:33
nyalldawson
nyalldawson reviewed Mar 8, 2020
View reviewed changes
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also drop the vcr_settings icon, and just use the existing settings.svg icon instead

src/app/qgisapp.cpp Outdated Show resolved Hide resolved
src/app/qgsprojectproperties.cpp Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.cpp Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.cpp Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Outdated Show resolved Hide resolved
src/core/qgstemporalproperty.h Outdated Show resolved Hide resolved
src/core/raster/qgsrasterdataprovidertemporalcapabilities.h Outdated Show resolved Hide resolved
src/gui/qgsmapcanvas.cpp Outdated Show resolved Hide resolved
src/gui/qgstemporalvcrdockwidget.h Outdated Show resolved Hide resolved
@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch 2 times, most recently from 65d9f56 to c617cf4 Compare March 10, 2020 18:31
@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from c617cf4 to 8981f9d Compare March 10, 2020 18:37
nyalldawson
nyalldawson reviewed Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for the updates!

src/app/qgisapp.cpp Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Outdated Show resolved Hide resolved
src/core/qgstemporalnavigationobject.h Show resolved Hide resolved
src/gui/qgstemporalcontrollerdockwidget.cpp Outdated Show resolved Hide resolved
src/gui/qgstemporalcontrollerdockwidget.cpp Outdated Show resolved Hide resolved
src/gui/qgstemporalcontrollerdockwidget.cpp Outdated Show resolved Hide resolved
src/gui/qgstemporalmapsettingswidget.cpp Outdated Show resolved Hide resolved
src/ui/qgstemporalcontrollerdockwidgetbase.ui
</widget>
</item>
<item>
<widget class="QDateTimeEdit" name="mStartDateTime">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a plain label instead of a widget -- the widget is confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do yo mean plain label?

Copy link
Member

@timlinux timlinux Mar 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He means the data should not be editable in the VCR I think @Samweli - let's chat about this just now

@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from 3169fd5 to 272852e Compare March 11, 2020 08:42
@Samweli Samweli force-pushed the temporal_navigation_vcr_widget_v2 branch from 272852e to bbb1e7c Compare March 11, 2020 13:40
@nyalldawson nyalldawson reopened this Mar 11, 2020
@nyalldawson
Copy link
Collaborator

@Samweli can you hold off on further changes to this branch ? Id like to merge to get th core components in place so that I can do a follow up cleanup. Let's defer further refinements to separate prs!

@Samweli
Copy link
Contributor Author

Samweli commented Mar 11, 2020

@Samweli can you hold off on further changes to this branch ? Id like to merge to get th core components in place so that I can do a follow up cleanup. Let's defer further refinements to separate prs!

Sure @nyalldawson

@nyalldawson nyalldawson mentioned this pull request Mar 12, 2020
Merged
@nyalldawson
Copy link
Collaborator

Superseded by #35007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timlinux timlinux timlinux left review comments

@nyalldawson nyalldawson nyalldawson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14 (Feature)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Samweli @saberraz @nyalldawson @timlinux @jef-n