Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strlen warnings on windows/vstudio #3492

Merged
merged 1 commit into from Sep 16, 2016
Merged

Remove strlen warnings on windows/vstudio #3492

merged 1 commit into from Sep 16, 2016

Conversation

ahuarte47
Copy link
Contributor

@ahuarte47 ahuarte47 commented Sep 15, 2016 •
edited

Remove strlen warnings from qgsgml.cpp on windows/vstudio

@ahuarte47 ahuarte47 changed the title Remove strlen warnings in windows/vstudio Remove strlen warnings on windows/vstudio Sep 15, 2016
m-kuhn
m-kuhn approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In general I think C++ style static_cast<> should be preferable but this file is pretty C-Style already.

@ahuarte47
Copy link
Contributor Author

Yes, You are right, but I tried preserve the current C-style

@m-kuhn m-kuhn merged commit c74d008 into qgis:master Sep 16, 2016
@ahuarte47
Copy link
Contributor Author

Thanks @m-kuhn !

@ahuarte47 ahuarte47 deleted the Issue_RemoveStrlenWarnings branch September 16, 2016 06:57
@qgib qgib mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahuarte47 @m-kuhn