If a dependent layer is redrawn, then also redraw child layer #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. This offers a clean solution for layer-dependent symbology to redraw itself (instead of the label obstacle hack). |
|
Ping @mhugo |
|
Sorry for the lag, I did not see the notification :/ It makes sense ! Thanks ! |
|
@mhugo thanks |
|
@mhugo... I've been wondering, is repaintRequested the right signal here or should this instead connect to dataChanged? I can see benefits both ways... |
|
@nyalldawson actually ... I am now wondering if this connection is needed. dataChanged() emitted from the provider should trigger a triggerRepaint on the layer (https://github.com/qgis/QGIS/blob/master/src/app/qgisapp.cpp#L10132). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a layer has a dependency on another layer, then trigger a redraw for the dependant layer whenever the other layer is redrawn.
@mhugo What do you think? Does this make sense to you?