[Server 3.0] now needs a qApp

[elpaso]

DO NOT MERGE!
READY TO MERGE

All the tests need to be adapted to Py3

[elpaso]

Initial fix for #3528
#3510

[nyalldawson]

@elpaso This looks great, and I'm really glad to see someone resurrecting these tests! Just a note (you may already be aware of this or not) but to get the tests to run on Travis you'll need to modify the blacklist (https://github.com/qgis/QGIS/blob/master/ci/travis/linux/qt5/blacklist.txt)

[sbrunner]

Initial fix for ...

It point himself ...

[elpaso]

@sbrunner bad cut/paste here is the link I wanted to add: #3510

[sbrunner]

@elpaso thanks :-)

[elpaso]

@sbrunner plase have have a look to the AC tests, I didn't check them, just quickly added the QgsApplication app creation which is now required.

[nyalldawson]

@elpaso I think it's just missing the QgsApplication import. Everything else looks good to me.

[sbrunner]

Tanks @elpaso good job :-)

[dmarteau]

Hi

@elpaso aeb5ff2 broke python bindings by making init() private:

/Users/david/Projets/qgis/QGIS/build/python/server/sip_serverpart1.cpp:42:21: error: 'init' is a private member of
      'QgsServer'
            sipCpp->init();
                    ^
/Users/david/Projets/qgis/QGIS/python/../src/server/qgsserver.h:88:17: note: declared private here
    static bool init();

[elpaso]

Did you run make clean ?

[dmarteau]

My bad,

make clean solve the issue.

[elpaso]

not completely yours: we had for ages something wrong in cmake or in the cmake config that does not rebuild sip bindings if the sip source files change, at least in some cases. If you could fix it it would be awesome.