Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose per-feature-source advanced options for processing inputs #35292

Merged
merged 15 commits into from Mar 24, 2020
Merged

Expose per-feature-source advanced options for processing inputs #35292

merged 15 commits into from Mar 24, 2020

Conversation

nyalldawson
Copy link
Collaborator

Among a ton of cleanups, this PR exposes per-feature-source advanced options, such as:

  • The ability to limit the number of features read from the source. (Useful in model development, you can easily test run models using a small subset of an input layer)
  • The ability to override on a per-input basis the global processing option for how to handle invalid geometries. Now you can safely leave the default processing setting at the conservative "Stop algorithm execution when a geometry is invalid" setting while easily temporarily overriding this for one particular input!

Peek 2020-03-24 16-00

Refs NRCan Contract#3000707093

@nyalldawson nyalldawson added Feature Processing Relating to QGIS Processing framework or individual Processing algorithms labels Mar 24, 2020
@nyalldawson
Copy link
Collaborator Author

Other exciting stuff here includes:

  • more Python -> c++ conversion
  • more unit tests
  • setting up the basis for processing widgets to utilise stacked panels (more use of this is inbound!)
  • a cleanup of the "iterate over input" option, including a new hi-dpi friendly svg icon

@github-actions github-actions bot added this to the 3.14.0 milestone Mar 24, 2020
alexbruy
alexbruy approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@alexbruy alexbruy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Very nice feature

@nyalldawson nyalldawson changed the title Panel Expose per-feature-source advanced options for processing inputs Mar 24, 2020
@nyalldawson
[processing] Cleanup handling of "iterate over source" buttons, move
f12c4cd 
creation completely to widget wrapper
@nyalldawson
Minor cleanup ParametersPanel
b9dd670
@nyalldawson
Cleanup unused imports
3181747
@nyalldawson
Remove unused processing icons
34687b6
@nyalldawson
[processing] Move iterate button to c++
e49cf0f
@nyalldawson
[processing] Move base class of ParametersPanel to c++
88af265
@nyalldawson
Remove some unused ui files
f0bf624
@nyalldawson
Make parameter panel a stacked panel
168601f
@nyalldawson
Fix exception when opening gdal algorithms
955239a
@nyalldawson
Allow serialization of QgsProcessingFeatureSourceDefinition through Q…
374179c 
…gsXmlUtils
@nyalldawson
Fix loss of callback when invalid geometry handling method is set thr…
3286b02 
…ough

source definition
@nyalldawson
[FEATURE][processing] Create widget for configuring advanced per-sour…
53081a2 
…ce options

Includes:
- optional limit on number of features processed from the source
- optional setting to override the default "invalid geometry handling" method
from the global processing options. Allows users to disable invalid geometry
handling on a per-input basis
@nyalldawson
[processing] Allow access to advanced per-feature-source input settings
41147a6 
via a new "options" button next to the source input box
@nyalldawson
Travis fixes
bf21e10
@nyalldawson
More Travis fixes
a1553df
@nyalldawson nyalldawson merged commit ab40162 into qgis:master Mar 24, 2020
@nyalldawson nyalldawson deleted the panel branch April 12, 2020 21:49
@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
@agiudiceandrea agiudiceandrea mentioned this pull request Mar 2, 2024
Merged
@agiudiceandrea
Copy link
Contributor

It looks like setting the CreateIndividualOutputPerInputFeature flag doesn't work. See: #56610.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbruy alexbruy alexbruy approved these changes

Assignees
No one assigned
Labels
Feature Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Milestone
3.14 (Feature)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyalldawson @agiudiceandrea @alexbruy @timlinux