Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatialite provider transactions #35488

Merged
merged 2 commits into from Apr 1, 2020
Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Mar 31, 2020

Transactions implementation for the native spatialite provider

Funded by: ARPA Piemonte

@elpaso elpaso added Feature Data Provider Related to specific vector, raster or mesh data providers labels Mar 31, 2020
@github-actions github-actions bot added this to the 3.14.0 milestone Mar 31, 2020
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (with the usual caveat that the larger transactions API is not completely thread safe. This pr follows the convention of the other transaction supported providers)

Are you aware that spatialite itself is on "death notice"? https://lists.osgeo.org/pipermail/qgis-developer/2020-March/060770.html

@elpaso
Copy link
Contributor Author

elpaso commented Apr 1, 2020

Lgtm (with the usual caveat that the larger transactions API is not completely thread safe. This pr follows the convention of the other transaction supported providers)

Are you aware that spatialite itself is on "death notice"? https://lists.osgeo.org/pipermail/qgis-developer/2020-March/060770.html

I didn't know, but I cannot say I'm particularly surprised (or sorry).
I guess we have to wait and see if anyone will continue to develop the library.

@SilvioGrosso
Copy link

SilvioGrosso commented Apr 1, 2020

Hello everyone,

Sorry to barge in...

Alessandro Furieri, the main developer of SpatiaLite, has been completely "silent" these past months on the SpatiaLite Google groups.

Here is the link to a post where he was asked about the future of SpatiaLite development, to which he has never replied:
https://groups.google.com/forum/#!topic/spatialite-users/RZPDuFfPhzs

I suppose Alessandro has some "health-issue" or has decided to stop working on SpatiaLite...
In the long past, he was quite responsive on the Google group, which is no longer the case now.

Maybe, a long shot here, just my personal opinion, the adoption of geopackage (instead of SpatiaLite) has also contributed to this lack of commits of development, by Alessandro, these past years (just supposing of course...).

@elpaso elpaso merged commit cac2d28 into qgis:master Apr 1, 2020
@elpaso elpaso deleted the spatialite-transactions branch April 1, 2020 09:15
@rouault
Copy link
Contributor

rouault commented Apr 1, 2020

has decided to stop working on SpatiaLite...

Not completely true: there was a commit by him just yesterday: https://www.gaia-gis.it/fossil/libspatialite/timeline . I had an email exchange with him a few weeks ago and he was super busy with other duties but hoped to be able to continue Spatialite development.

@nyalldawson
Copy link
Collaborator

I wonder if funding is his issue. I think we could/should put out a "call for support" via the QGIS news feed. I think given the widespread use of spatialite databases, and the likelihood that there's organisations out there which are entirely reliant on them, we should be able to find sponsors for a maintenance effort. (If so, it might be a good opportunity to also fund the spatialite project moving to a modern git-based workflow which is more inviting to other contributors,...)

@nirvn
Copy link
Contributor

nirvn commented Apr 1, 2020

@nyalldawson , +1 to all of that, it'd be a real shame to see spatialite die out.

@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Provider Related to specific vector, raster or mesh data providers Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants