Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer mask source widget population (fixes #34942) #35557

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

mhugo
Copy link

@mhugo mhugo commented Apr 3, 2020

Description

Defer the loading of masking widgets (mask sources and targets) in the layer properties.

They are loaded only on explicit user request, when the user ticks a checkbox.

Capture d’écran de 2020-04-03 16-22-53

Should fix #34942

[Replace this with some text explaining the rationale and details about this pull request]

@mhugo mhugo added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Apr 3, 2020
@github-actions github-actions bot added this to the 3.14.0 milestone Apr 3, 2020
@nyalldawson
Copy link
Collaborator

Fix looks good! Can you fix the widget alignment in the panel though? (label vs treeview). The layout would look nicer (and more consistent with the other tabs) if you used a checkable group box here instead of the seperate qcheckbox/qframe approach.

@SteveLowman
Copy link

Does this mean the merge has been completed?

@mhugo
Copy link
Author

mhugo commented Apr 7, 2020

@nyalldawson Yes indeed, thanks for the reminder. That should be better now.

@SteveLowman Not yet, I'll merge once the automatic tests are ok and will tell you.

@SteveLowman
Copy link

@mhugo I downloaded and installed Friday's nightly build, but the fix does not seem to be there. Should I still be waiting?

@mhugo
Copy link
Author

mhugo commented Apr 14, 2020

@SteveLowman Well it should be there in the "qgis-dev" version (3.13.0-27) and it should now also be in the "qgis-rel-dev" (3.12.1-10) that can be installed through the OSGeo4W installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
3 participants