Allow copying/cut/paste of model components #35644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added
Requires Tests!
alexbruy
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Looks good.
But I'm no sure if we should paste also all child items by default, in some cases this is not necesary and user will need to remove unused items after pasting. Maybe we should have two paste actions: one for pasting selected items and another one for pasting selected items and their childs
|
What about if we only copy the comments/outputs if they are manually selected? |
|
Sounds good to me. But I'm not an UX expert, probably we should also ask @nirvn. |
|
Sorry, I've not seen my name mentioned here until now. I think @nyalldawson 's proposal is good. |
|
Ok, implemented. This is much nicer logic, thanks! |
This commit allows users to copy and paste model components, both within the same model and between different models
connected to algorithms when they have been explicitly selected by the user
nyalldawson
removed
the
Requires Tests!
timlinux
added
Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to copy and paste model components, both within the same model and between different models
Refs NRCan Contract#3000707093