Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msvc utf-8 #35737

Merged
merged 10 commits into from
Apr 14, 2020
Merged

Fix msvc utf-8 #35737

merged 10 commits into from
Apr 14, 2020

Conversation

longhuan2018
Copy link
Contributor

Solve the errors caused by utf-8 encoding under Chinese windows operating system, using msvc compilation

@nyalldawson
Copy link
Collaborator

This change has broken some tests -- see https://dev.azure.com/qgis/QGIS/_build/results?buildId=4098&view=ms.vss-test-web.build-test-results-tab. Are you able to investigate please?

@longhuan2018
Copy link
Contributor Author

This change has broken some tests -- see https://dev.azure.com/qgis/QGIS/_build/results?buildId=4098&view=ms.vss-test-web.build-test-results-tab. Are you able to investigate please?

https://doc.qt.io/qt-5/qstring.html#QStringLiteral

Note: Some compilers have bugs encoding strings containing characters outside the US-ASCII character set. Make sure you prefix your string with u in those cases. It is optional otherwise.

@nyalldawson
Copy link
Collaborator

Thanks! Let's see if this round passes

@nyalldawson nyalldawson merged commit 4e9e636 into qgis:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants