Fixed fetching NULL bigint pgsql attributes. Fixes #36011 #36124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
approved these changes
May 1, 2020
|
Thanks a lot for testing, reporting and fixing ! |
|
@m-kuhn , the Travis failed test looks unrelated to me; test 569 ( PyQgsPostgresProvider ) there passed before 595 (PyQgsServerWMSGetPrint) segfaulted. Can you merge even so? Thanks. |
|
@espinafre It seems to be working fine! A big thank you to all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an omission from handling bigint fields in PostgreSQL, related to PRs #35162 (backported to QGIS 3.12 with PR #35832) and #36040 (backported to QGIS 3.12 via PR #36063). I've added a new check in the tests for this fix.
@m-kuhn , may you please take a look? This really needs to be backported to 3.12. Thank you very much.
@tudorbarascu , the fix is simple, really, maybe you can try it in your local repo to see if there are any omissions. Also pinging @gioman . Thank you all for reporting, and I'm very sorry to have missed this.