Allow customisation of division and subdivision symbols as distinct from scalebar tick horizontal symbol #36222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because **maybe** someone will want subdivisions bigger than divisions, and there's no need to artificially restrict their creativity!
…mbol as distinct symbols vs the scalebar line symbol Allows for styling division and subdivision symbols in a different way compared with the horizontal line symbol in a tick scalebar Sponsored by SLYR
nyalldawson
added
Feature
Print Layouts
nirvn
reviewed
May 6, 2020
|
This is a big enhancement! Just a note about removing the subdivisions tick height restriction: to properly handle the subdivisions tick height > segments tick height case, I think some changing should be made in how the BoxSize and the position of the horizontal bar are calculated, and how the polyline of the segments ticks is generated. |
|
I wondered the same thing, but when testing found that you can handle this by adjusting the label distance manually, and that it seemed quite natural to do... I'd suggest we merge and to give it a test in practice and then determine if we want to automatically handle this situation in the scalebar layout code or not... |
timlinux
added
Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for styling division and subdivision symbols in a different
way compared with the horizontal line symbol in a tick scalebar
Sponsored by SLYR
Builds off the hard work done by @agiudiceandrea!