Fix SIP QgsSnapToGridCanvasItem class declaration #36240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
backport release-3_10
Bug
|
Can you provide a detailed explanation of why this is required? This looks like one of the pull requests someone will look at in 3 years time and wonder "what was the reason for that". |
When you edit some vector, QgsSnapToGridItem is added to the scene and so the following Python instruction will make QGIS crash iface.mapCanvas().items()It looks like SIP doesn't like double inheritance. To be honest, I find the solution in one for your previous commit #32755 |
|
Ah, thanks (for ref. most complete explanation here b648a64) |
m-kuhn
approved these changes
May 7, 2020
This was referenced May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36033 : missing SIP_RUN class specific declaration