[processing][db_manager] Fix connection to postgis #3635
Conversation
arnaud-morvan
changed the title
|
Is it still a work in progress ? |
|
I've put WIP on this, because I was surprised no one have raised or fixed this since master use QT5 / Python3. I've not sure about the source of the error, why we get null variants here, and I've not got the time to search more deeply on this subject. |
arnaud-morvan
force-pushed
the
processing_postgis_connect
branch
from
e8256b4
to
9cd39e7
Compare
arnaud-morvan
changed the title
|
Seems really needed, can some one take a look and merge. |
| @@ -59,6 +59,9 @@ def uri_from_name(conn_name): | |||
|
|
|||
| settings.endGroup() | |||
|
|
|||
| if hasattr(authcfg, 'isNull') and authcfg.isNull(): | |||
There was a problem hiding this comment.
This part looks a bit awkward to me
Why is the hasattr(authcfg, 'isNull') needed ? Are there case where authcfg wouldn't be a QString ?
And then why transforming a null QString into an empty QString ?
Shouldn't rather setConnection() be made robust to support null strings in addition to empty strings.
There was a problem hiding this comment.
The problem is that QSettings do not return a NULL QString, but a NULL QVariant :
arguments did not match any overloaded call:
QgsDataSourceUri.setConnection(str, str, str, str, str, QgsDataSourceUri.SslMode sslmode=QgsDataSourceUri.SslPrefer, str authConfigId=QString()):
argument 7 has unexpected type 'QVariant' QgsDataSourceUri.setConnection(str, str, str, str,
QgsDataSourceUri.SslMode sslmode=QgsDataSourceUri.SslPrefer, str authConfigId=QString()):
argument 5 has unexpected type 'str' See log for more details
Fix some postgis connection errors, probably due to Python3.