Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different point symbols for QgsRubberband. #366

Merged
merged 2 commits into from Dec 27, 2012

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Dec 25, 2012

As discussed in the previous pull-request, this adds the possibility for several different point markers.

QgsVertexMarker should be subject to be removed as soon as this pull-request gets accepted.

@NathanW2
Copy link
Member

Any objections from anyone to merge this one?

@mhugent
Copy link
Contributor

mhugent commented Dec 26, 2012

Isn't it necessary to consider also the pen width in qgsrubberband.cpp:482?
Otherwise it looks good to me, +1 for merge

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 26, 2012

I was thinking about it, but it wasn't considered before for outlines of
polygons and lines neither and I did not notice any artifacts so far.
But if it's necessary, please tell me and I'll include it as well.

Another thing is, that when using with polygon or line, the rect which
is considered for update has a "buffer" of half an icon size around it,
but that's a slight performance hit at max.

@mhugent
Copy link
Contributor

mhugent commented Dec 26, 2012

Please add the pen width, it is saver. I think it was just luck that it worked so well with the rubberband so far.

@m-kuhn
Copy link
Member Author

m-kuhn commented Dec 26, 2012

Done.

Note:
If there are any more changes required, I might have a little time tomorrow and after that I'll be unavailable until Jan 3.

mhugent added a commit that referenced this pull request Dec 27, 2012
Add different point symbols for QgsRubberband.
@mhugent mhugent merged commit f815a72 into qgis:master Dec 27, 2012
@mhugent
Copy link
Contributor

mhugent commented Dec 27, 2012

Merged, thank you Matthias.

@NathanW2
Copy link
Member

That was close. I was just about the merge this pull request :)

@m-kuhn
Copy link
Member Author

m-kuhn commented Mar 8, 2013

Marco, FYI:

http://hub.qgis.org/issues/6987

Looks like we got already bitten by the pen width, depending on the client (graphics driver or so...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants