[processing] fix handling for stdout and file outputs in GRASS #36618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
Processing
|
@nyalldawson may I ask you to take a look? |
|
I've got to admit, I don't fully understand the logic here (the original logic & the new logic 😄 )! But I do know that since 3.0 there's been a number of disabled grass tests which relied on html outputs. I wonder if these relate to the same underlying cause and could now be re-enabled? |
|
Probably I have missed when we disabled some GRASS tests but there are some broken algs and I'm about to submit another PR which fixes them and adds tests. Will check if there are any disabled tests and try to re-enable them. |
This was referenced May 22, 2020
algorithms when temporary files are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found this when working on another issue in Processing GRASS provider.
"Fake" (redirected from stdout) outputs in GRASS algorithms does not handled correctly if destination is temporary file. Algorithms just fail with Python error saying "File 'TEMPORARY_OUTPUT' does not exists". Normal file outputs works almost fine, except that in the log instead of valid output path we got also
TEMPORARY_OUTPUTliteral.Proposed PR fixes this by maintaining mapping between output name and destination path. This mapping then used to produce results map and also for converting text outputs into HTML.