-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QgsBinaryWidgetWrapper: fix focus-related crash #36722
Conversation
Will be use to solve crash of qgis#30210 Credits to @nyalldawson for pointing out the fix of qgis#31905 as a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new class could be used for the resource widget too, right?
probably. Didn't want to go too far before checking if this approach was acceptable. |
PR implementing this in #36734 |
Question w.r.t backport bot: as this PR is made of several commits, which merge option should I use ? |
It doesn't really matter - I've started manually collecting backports in #36718 , where they wait until the next LTR release before merge. This way they get a full month in a stable release to avoid regressions in the LTR patch releases. I personally prefer a linear git history with no merges, but @m-kuhn will fight me on that! |
hum, is this is a new general policy ? Should I still tag this PR with "backport release-3_10" ? Or if I do it, then the backport PR shouldn't be merged right away ? |
It's an informal policy @m-kuhn and I developed. I need to file a QEP and get it formally accepted. The rough process is:
|
ok, got it |
Technically it should be totally doable to create a fully working backport bot (a modernized version of the original one - the one we have grown to like so much - as github action), including cross-repository pull request support. |
Fixes #30210