Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use completeBaseName for world file when exporting layouts (fix #34523) #36742

Merged
merged 2 commits into from
May 26, 2020
Merged

use completeBaseName for world file when exporting layouts (fix #34523) #36742

merged 2 commits into from
May 26, 2020

Conversation

alexbruy
Copy link
Contributor

Description

If file name of the exported layout contains multiple dots (like "Export.2020.04.03.png") worldfile will be generated with incorrect name, stripped at the first dot.

Fixes #34523.

@alexbruy alexbruy added Bug Either a bug report, or a bug fix. Let's hope for the latter! Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks backport release-3_10 labels May 26, 2020
@alexbruy alexbruy requested a review from nyalldawson May 26, 2020 13:55
@nirvn
Copy link
Contributor

nirvn commented May 26, 2020

@alexbruy , is this an issue for the save map canvas as image function?

@alexbruy
Copy link
Contributor Author

@nirvn I will check

@alexbruy
Copy link
Contributor Author

Also fixed in the saveAsImage() method of the QgsMapCanvas class. Exporting with QgsMapRendererTask already uses completeBaseName.

@nirvn
Copy link
Contributor

nirvn commented May 26, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
3 participants