QgsVectorLayerSaveAsDialog: make it work with custom CRS #36758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
added
Bug
nyalldawson
reviewed
May 26, 2020
The current approach was based on a srsid, that that might be unset for custom CRS. So store a full QgsCoordinateReferenceSystem object internally and use that for exchanges with QgsProjectionSelectionWidget Consequence: we need to deprecate the "long crs()" method, and replace it by a "QgsCoordinateReferenceSystem crsObject()" one. I'm not particularly happy with the name but the existing one was not very well named... Mark also the QgsVectorLayerSaveAsDialog( long srsid, ... ) constructor as deprecated Fixes the use case of qgis#34471 (comment)
rouault
force-pushed
the
fix_qgsvectorlayersaveasdialog_with_custom_crs
branch
from
08f04ba
to
d960d0e
Compare
nyalldawson
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach was based on a srsid, that that might be unset for custom
CRS. So store a full QgsCoordinateReferenceSystem object internally and use
that for exchanges with QgsProjectionSelectionWidget
Consequence: we need to deprecate the "long crs()" method, and replace it
by a "QgsCoordinateReferenceSystem crsObject()" one. I'm not particularly
happy with the name but the existing one was not very well named...
Mark also the QgsVectorLayerSaveAsDialog( long srsid, ... ) constructor as
deprecated.
Fixes the use case of #34471 (comment)