improve logic for choosing style type when exporting raster style (fix #35944) #36774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
GUI/UX
|
Probably we even should not rely on the manually entered extension and only take into account selected file filter. |
nyalldawson
approved these changes
May 27, 2020
That sounds good! |
|
Ok, chnaged to use only file filter to determine style type. First comment also updated to reflect changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, when user tries to save raster style to SLD and entered filename without
.sldextension in the save dialog, style will be exported as QML even if SLD filter is selected.Proposed PR changes logic to rely only on the selected filter to determine style type (QML or SLD). So if for example SLD filter is selected but file name has
.qmlextension style will be exported as SLD and file will have suffix.qml.sld.Fixes #35944.