allow to export favorite symbols from style manager (fix #27315) #36793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
GUI/UX
|
While looking at this I also notices couple of other issues:
|
|
Don't know why indentation test failed. I have run |
nyalldawson
approved these changes
May 28, 2020
Let's skip it -- it's not a high priority fix IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exporting symbols from Style manager one can select symbols with mouse or using "Select by group" button. The latter allows to select symbols which belong to some smart group or tag but it is not possible to select favorite symbols.
Proposed PR adds "Favorites" group to the "Select by group" dialog to allow selecting favorite symbols and make it consistent with group selector in the Style manager itself.
Fixes #27315.
Not sure about backport to 3.10.