FIX #35196, layer was not set on QgsFieldExpressionWidget #36824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienPeillet
force-pushed
the
QgsFieldExpressionWidget_not_populated_in_QgsAttributeFromContainerEdit
branch
from
172c8fd
to
39e40f2
Compare
nyalldawson
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes issue #35196 . As explained by @Gustry, the visibility expression filter for container is not populated with layer's fields in the attributes form configuration (Drag and Drop mode) :
Usually we set the reference layer to QgsFieldExpressionWidget, so it can use layer's fields in expression filter. But it wasn't done for QgsAttributeFormContainerEdit.
Simple as this :) :
I don't know if there is a test to do for this. QgsFieldExpressionWidget is already tested