Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review comment from #36823 #36828

Merged
merged 1 commit into from May 30, 2020
Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented May 29, 2020

Description

A smaller and slighty more generic version of #36823 .

@m-kuhn m-kuhn requested a review from elpaso May 29, 2020 14:30
@github-actions github-actions bot added this to the 3.14.0 milestone May 29, 2020
Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's more elegant than mine but basically the same functionality.

And what about the strip ( \n\r ) of your original proposal (that I didn't find related), did you find a better way?

@m-kuhn
Copy link
Member Author

m-kuhn commented May 29, 2020

It's more generic than the original version, as it also handles semicolons that are followed by whitespace or comments.

It implements the following part of the original comment

or do the check on the uncommented sql (which removes newlines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants